search

dwmkerr / node-imagemagick-cli

Access the ImageMagick CLI tools from Node. No dependencies, cross-platform, with support for ImageMagick 6 and 7.
8 stars 2 forks source link

fix: windows im 7.0.1 q16 #31

Open dwmkerr opened 4 years ago

dwmkerr commented 4 years ago

This is a continuation of the work in #27

dwmkerr commented 4 years ago

@RaschidJFR still having issues here unfortunately, it looks like in exec, the second call to pickCli fails and kills the process immediatly, with no output at all. I've tried stepping through with the debugger and cannot see what might be going wrong.

Quick question: would one alternative fix be to always just convert from command parameters to magick command parameters, and simplify the logic like that? Does IM 6 support just calling magick convert -version for example? If so, I can update the code so that we simply look for the magick cli and use that...

RaschidJFR commented 4 years ago

Hi, sorry for my late reply. I'm not sure I'm following you.

I've just tested and yes, the only failing test is 1) should prefer a command in an 'ImageMagick' folder on windows in exec.

And yes, $ magick convert -version works on windows and gives me this output:

Version: ImageMagick 7.0.9-2 Q16 x64 2019-10-30 http://www.imagemagick.org
Copyright: Copyright (C) 1999-2018 ImageMagick Studio LLC
License: http://www.imagemagick.org/script/license.php
Visual C++: 180040629
Features: Cipher DPC Modules OpenCL OpenMP(2.0)
Delegates (built-in): bzlib cairo flif freetype gslib heic jng jp2 jpeg lcms lqr lzma openexr pangocairo png ps raw rsvg tiff webp xml zlib