dwmkerr / terraform-aws-openshift

Create infrastructure with Terraform and AWS, install OpenShift. Party!
http://www.dwmkerr.com/get-up-and-running-with-openshift-on-aws
MIT License
170 stars 174 forks source link

Running make infrastructure fails with error #83

Closed mmussett closed 5 years ago

mmussett commented 5 years ago

$ make infrastructure

Get the modules, create the infrastructure.

terraform init && terraform get && terraform apply -auto-approve Initializing modules...

Initializing provider plugins...

The following providers do not have any version constraints in configuration, so the latest version was installed.

To prevent automatic upgrades to new major versions that may contain breaking changes, it is recommended to add version = "..." constraints to the corresponding provider blocks in configuration, with the constraint strings suggested below.

Terraform has been successfully initialized!

You may now begin working with Terraform. Try running "terraform plan" to see any changes that are required for your infrastructure. All Terraform commands should now work.

If you ever set or change modules or backend configuration for Terraform, rerun this command to reinitialize your working directory. If you forget, other commands will detect it and remind you to do so if necessary.

Error: module.openshift.aws_route53_zone.internal: "vpc_id": [REMOVED] use 'vpc' configuration block instead

make: *** [infrastructure] Error 1

krishan03 commented 5 years ago

In the modules/openshift folder, make the following change in the 07-dns.tf file:

just replace vpc_id = "${aws_vpc.openshift.id}" line with vpc { vpc_id = "${aws_vpc.openshift.id}" }

dwmkerr commented 5 years ago

Well spotted - fixing it now. I noticed this when forking over to terraform-aws-kubernetes (which I've not published yet). Will update in a min

dwmkerr commented 5 years ago

Resolved in master, thanks all!