search

dwonderley / mookAI

If you encounter problems, please leave an issue or message me on the FVTT discord with the handle @Daveofwonders
MIT License
9 stars 13 forks source link

Not making attack rolls #2

Closed Avitale34 closed 4 years ago

Avitale34 commented 4 years ago

Wow this module is amazing!!! Its the targeting and movement is working great for me but it is not rolling attacks for some reason.

Avitale34 commented 4 years ago

Edit: seems to be an incompatibility with MIDI QOL

dwonderley commented 4 years ago

I thought I had midi-qol working at some point. I'm probably not up to date. Let me look into it...

dwonderley commented 4 years ago

I remember now. I disabled it when 0.7.5 hit because a few of its dependencies hadn't updated yet. I assume that, since you're using it, that isn't a problem any more. I'll update and correct the compatability issue.

dwonderley commented 4 years ago

From midi-qol documentation: "Better Rolls If you are using BetterRolls (which is a great module), midi-qol takes over once the hit/damage card is placed by better rolls. This means that resource consumption, template placement and critical/fumble determination is all handled by BetterRolls before midi-qol kicks in. Midi-qol checks hits, saves, applies damage and calls active effects."

I believe this means I need to invoke better rolls directly, if it is enabled, so I will remove the check for midi/minor-qol, and I have tested that damage will be rolled correctly this way with each module combination.

Avitale34 commented 4 years ago

Thank you for looking into that! I do not have Better Rolls installed just MidiQOL! Look forward to using this great mod!

dwonderley commented 4 years ago

The fix should be live now. I'm verifying it now. I'm sorry it took so long; I'm new to git and finding it absolutely awful compared to other version controls I've used.

Avitale34 commented 4 years ago

I don't think foundry has the updated version yet. I just uninstalled and reinstalled and its still 0.0.1. Appreciate the swiftness of your response!

Avitale34 commented 4 years ago

Works great now! Can I put in a feature request to apply "multiattacks" not sure if that's even possible.