dwoo-project / dwoo

[UNMAINTAINED] php template engine
http://dwoo.org
GNU Lesser General Public License v3.0
167 stars 58 forks source link

Incompatibility with PHP 7 #44

Closed domymg closed 7 years ago

domymg commented 8 years ago

There is a bug when you try to use Dwoo with PHP7. When try to acess from a template to a object var.

It is in Core class, in readVarInto: $data = $data->$m[2][$k];

has to be:

$attr = $m[2][$k];
$data = $data->$attr;
emulienfou commented 8 years ago

Dwoo move to GitLab, this bug has been fixed to the 1.3.0 release who will be out soon!

themightychris commented 8 years ago

@emulienfou is this GitLab repository public? I wasn't able to find it but it looks like this github repo IS active...

emulienfou commented 8 years ago

Hi, @themightychris just redefine all my development process for this project. This project is still hosted on GitHub has a public repository.

Hi, also had now a private mirrored repository hosted on GitLab to the future development with Continuous Integration.

PHPUnit tests are still available and will continued to be used is the future. The 1.2.x and `1.3.x versions are now tested on PHP5.3 to PHP5.6 for improve more stability on the future deliveries.

emulienfou commented 8 years ago

To answer to this issue, YES a future 1.4.0 is now in the development process to be compatible by PHP7.x

themightychris commented 8 years ago

@emulienfou is 1.4.0 what you're working on in the current master branch here on GitHub? I might contribute to that effort if it is happening on GitHub

emulienfou commented 8 years ago

Here is a view of the future works for Dwoo, how I put a final version on the public repository:

GitHub

GitLab

Here is the future timeline of developments of this project.

If you want to contribute on this project it will be really appreciated, you can send me a private message with your GitLab login to give you access to my repository.

themightychris commented 8 years ago

@emulienfou so the 1.4 branch is not accessible anywhere public yet? Could you push that to github when you get the chance so I might try it out and contribute PRs?

emulienfou commented 8 years ago

Like I said, I'm working on the 1.3 branch, the 1.4 is not yet create. If you want to contribute I can give you access to my GitLab repository.

themightychris commented 8 years ago

@emulienfou thanks I would appreciate that!

emulienfou commented 7 years ago

Fixed from 1.3.1 release, now compatible with PHP7.0 and PHP7.1.