Add typescript for this module?

dword-design / nuxt-mail

Adds email sending capability to a Nuxt.js app. Adds a server route, an injected variable, and uses nodemailer to send emails.

Other

239 stars 18 forks source link

Add typescript for this module? #208

Open truongnat opened 11 months ago

BobbieGoede commented 3 weeks ago

@dword-design I figured I would add some types and use @nuxt/module-builder to build the module and open a PR, but it ended up much more involved than I expected... 😅

I ended up forking the repo and publishing a separate package https://github.com/BobbieGoede/nuxt-mail since I had to change most of the code. Your work is very much appreciated, it's not my intention to compete, maybe moving this module to the nuxt-modules org makes more sense?🤔

dword-design commented 12 hours ago

@BobbieGoede Looks great! I have some blockers with TypeScript (missing babel plugin support), so I'd not fully migrate to TypeScript now. But we could add a typings file.