dworkin / lpc-ext

Extension modules for Hydra and DGD
The Unlicense
9 stars 5 forks source link

Cannot use upgrade command with JIT module loaded #1

Closed november-kilo closed 5 years ago

november-kilo commented 5 years ago

After adding the jit module, cloud-server's upgrade command does not complete and I have to kill the mud.

november-kilo commented 5 years ago

I pulled a fresh cloud-server repo and it doesn't occur there. I must have messed up something. I'll close this.

november-kilo commented 5 years ago

I was wrong. The upgrade command works the first time, but not the second time.

> ls /lib
ChainedContinuation.c*    GMTime.c*                 String.c*
Continuation.c*           IntIterator.c*            StringBuffer.c*
ContinuationToken.c*      Iterable.c*               Time.c*
DelayedContinuation.c*    IterativeContinuation.c*  util/
DistContinuation.c*       Iterator.c*
> upgrade /lib/Time.c
Successfully upgraded:
  /lib/Time.c
> upgrade /lib/String.c
dworkin commented 5 years ago

@november-kilo 4d5cdc6fb2af9dbdf16ff4ea5d194caa56444ebc should fix this problem, please give it a try.

dworkin commented 5 years ago

When rebuilding the JIT compiler, please make sure to clear the cache. Otherwise, the JIT compiler will assume that the previous JIT-generated code can be reused.

november-kilo commented 5 years ago

@dworkin Cleared cache and rebuilt. No problems with upgrade command. 👍

dworkin commented 5 years ago

Thank you for reporting this bug.