search

dwp-forge / refnotes

4 stars 6 forks source link

Refnote does not allow note names with dashes in them #17

Closed dwp-forge closed 9 years ago

dwp-forge commented 9 years ago 
What steps will reproduce the problem?
1. Link to a note-name with a dash, for example [(van-aalst1999knowledge)]
2. Link does not work

I use refnotes with the reference database, with a bibliography generated from a bibtex
file. It works amazingly well, however it breaks on reference names that have dashes.
The citekeys are automatically generated by bibdesk based on the first author's last
name, and the first word of the title. If either has a dash in it (ie. Berg-Stromssen,
or Inter-relations), the key will not be usable with refnotes.

It would be great if refnotes allowed keys with dashes in them.

Thanks for an amazing program. I will create a screencast soon about how I use it as
part of my "integrated information workflow"

Original issue reported on code.google.com by shaklev on 2011-05-19 08:32:29

dwp-forge commented 9 years ago 
The note names are constrained is by design[1]. This is done in order to minimize false
positives. For example, one can have a date as the note text [(May-19-2011)].

I will consider improving name detection logic in future versions, and maybe it will
allow to release the constrains.

[1] http://www.dokuwiki.org/plugin:refnotes:syntax#named_notes

Original issue reported on code.google.com by dwp-forge on 2011-05-19 09:08:53

dwp-forge commented 9 years ago 
Thank you for your feedback. I totally understand your concern. For now, is there some
quick hack in the source code I could do to disable this constraint in my version -
I am using refnotes solely for database references, no text footnotes. 

Stian

Original issue reported on code.google.com by shaklev on 2011-05-19 09:51:28

dwp-forge commented 9 years ago 
In the next release fully-qualified note names (start with colon) will allow the following
characters:
    .&()[]{}+-

The same rule also applies to references that define a note (both simple "[(n-1>Text)]"
and structured "[(n-2>page:42)]") and notes in the reference database. So it should
be possible to have a database note "Smith&Jones(2012)" and reference it on a page
as "[(:Smith&Jones(2012))]."

Namespace names are still limited to alphanumeric characters and underscores. They
are used as part of element identifiers in generated HTML, so there are only few characters
that can be added without breaking HTML. Though dashes are allowed in HTML id's, I
don't think it's worth the trouble.

Implemented in r486.

Original issue reported on code.google.com by dwp-forge on 2012-05-13 17:10:11