search

dwp-forge / refnotes

4 stars 6 forks source link

Prevent direct access to '$this->plugin->lang' ('lang' variable of class 'DokuWiki_Plugin') #46

Closed lpaulsen93 closed 6 years ago

lpaulsen93 commented 6 years ago

This is a very simple approach to fix the problem. New js_ and dbk_ strings would need to be added manually now to functions getLangJSPrefix() and getLangDBKPrefix(). But it might be acceptable as there were not much changes in the past.

dwp-forge commented 6 years ago

This solution is way to intrusive and has questionable maintainability. I have pushed a patch that fixes the issue.

lpaulsen93 commented 6 years ago

Fine for me. I had to read about what a trait is and it seems to be the best solution. Thanks for fixing this.