search

dwp-forge / refnotes

4 stars 6 forks source link

Default CSS style for RefNotes tooltip #75

Closed eduardomozart closed 1 year ago

eduardomozart commented 1 year ago

Hello, Some templates like "Read the Dokus" and "Argon Alternative" normalizes the CSS from browsers (removing it's default values from CSS properties) so they can customize all elements from page without worrying with browser inherit styles. But consequentely it breaks the CSS from RefNotes tooltips, as can be seen below:

image

It seems that the default CSS used by the default DokuWiki template is:

div.insitu-footnote.JSpopup {
    background-color: #fff;
    color: inherit;
    border: 1px solid #ccc;
    box-shadow: .1em .1em .1em #ccc;
    border-radius: 2px;
    padding: .3em .5em;
    font-size: .9em;
}

Adding them at the userstyle.css, the tooltip style are rendered as expected:

image

It would be great if RefNotes applies a default style for Tooltips to ensure they are styled as expected.

dwp-forge commented 1 year ago

To me that appears to be a template issue. RefNotes popup style is supposed to match the style of DokuWiki footnotes, which is supposed to be a part of template. So I would avoid forcing the style from a plugin, as it may conflict with templates that do customize it.

How do popups for DokuWiki footnotes look like on this template?

eduardomozart commented 1 year ago

I see, thank you for your feedback. I’ll check with the template author and I’ll let you know.

eduardomozart commented 1 year ago

I reopened the issue https://github.com/my17560/dokuwiki-template-readthedokus/issues/36 with the plugin author so we was able to recognise it was related to a core DokuWiki feature (footnotes) instead of a specific style applied only for RefNotes plug-in, so he added it to the template and now tooltips are rendered as expected. Thank you!