dwp / design-system

One place for service teams to find and share the styles, components and patterns for designing DWP services.
MIT License
15 stars 3 forks source link

Favicon not visible using Dark browser themes #489

Open martinwake opened 1 year ago

martinwake commented 1 year ago

What

The favicon for the Design System site is not visible against a dark background, for example when using Chrome with the Dark theme enabled: image

Why

This is an opportunity to review the favicon against any relevant standards or good practice and update it if needed.

Done when

Who needs to know about this

Design system team

Anything else

The DWP Digital careers website uses this favicon: https://careers.dwp.gov.uk/wp-content/uploads/2019/09/dwp_digital_logo_website.png?x64953

Related Issues

mitz-lad commented 1 year ago

Updated favicon

android-chrome-192x192

Dark mode

image

Light mode

image

Preview on branch: https://gitlab.com/dwp/dwp-design-system/main-site/-/tree/feature/house-keeping?ref_type=heads

Trialled the logo on different backgrounds and variations and implemented the version which is recognisable at 16px x 16px which is the white emblem on black background. This is inline with the crown logo used on gov.uk. The use of the score line on the left forces the logo to scale down even further which makes it less recognisable.

Other Design systems use their emblem in white on their brand colour e.g. MOJ

image

This would not work for the Design system site as DWP brand colour is an aqua green which does not create a visual coherence with the main site accent colour being purple.


Trials

image
mitz-lad commented 1 year ago

House keeping branch also has other updates that require completing before release see: Housekeeping: Team page updates and DWP Logo #542

jonhurrell commented 10 months ago

@mitz-lad There was a recent slack conversation which might help fill some wider context for a standardise opportunity.