dwp / design-system

One place for service teams to find and share the styles, components and patterns for designing DWP services.
MIT License
15 stars 3 forks source link

Housekeeping: Team page updates and DWP Logo #542

Closed mitz-lad closed 9 months ago

mitz-lad commented 1 year ago

What

Housekeeping tasks

Why

Team page done when

DWP logo done when

Related issues

mitz-lad commented 1 year ago

Updates on feature/house-keeping branch. This branch also contains update to favicon see Favicon not visible using Dark browser themes #489

Requires cross browser testing and accessibility testing on logo to release.

mitz-lad commented 10 months ago

Team page updates

Created new branch f-team-page with fixes as feature/housekeeping branch got messy with other fixes.

Preview: https://f-team-page.design-system.dwp.gov.uk/index

Added default avatar for team page profile images

image

Fixed line break issue Currently email addresses break the layout

Fixed by changing html from <ul> to <dl> as content is key-value pairs and setting line break behaviour.

mitz-lad commented 10 months ago

Added DWP logo to header

Created new branch f-logo with changes as feature/housekeeping branch got messy with other fixes.

Preview: https://f-logo.design-system.dwp.gov.uk/index

image image image image



SVG is about 46kb, and has been implemented as an image, so it should be cached after the the initial load. Optimisation tool reported by gzipping the file it can be reduced to about 17kb. Adding an additional task to the ticket for this.

Header has been implemented in Chrome Version 120.0.6 - accessibility and browser testing will be required.

jonhurrell commented 10 months ago

Added DWP logo to header

Created new branch f-logo with changes as feature/housekeeping branch got messy with other fixes.

Preview: https://f-logo.design-system.dwp.gov.uk/index

image image image image

  • Added SVG logo to header
  • CSS for responsive behaviour (Tested in Chrome)
  • Checked for relative url for different pages - needs seconds eyes just in case I missed anything

SVG is about 46kb, and has been implemented as an image, so it should be cached after the the initial load. Optimisation tool reported by gzipping the file it can be reduced to about 17kb. Adding an additional task to the ticket for this.

Header has been implemented in Chrome Version 120.0.6 - accessibility and browser testing will be required.

@mitz-lad Complete the reach out for any branding guidance, but as agreed, we'll move this into an upcoming collection of task around redesign work.

mitz-lad commented 10 months ago

Created merge request with main - ready to deploy to live