search

dwp / govuk-casa

Framework for creating simple GOVUK Collect-And-Submit-Applications
ISC License
34 stars 24 forks source link

Error summary link hrefs should focus form element #5

Closed colinrotherham closed 5 years ago

colinrotherham commented 5 years ago

The GOV.UK Design System recently added better examples for how the summary links integrate with form fields that have errors.

e.g. https://design-system.service.gov.uk/components/error-summary/linking/index.html

But we've found:

In CASA The error summary href incorrectly links to the error span[govuk-error-message] element

In the Design System The error summary href correctly links to the input field

error summary link

If we fix this in CASA, thanks to the recent GOV.UK Frontend 2.4 ErrorSummary component, it'll handle all the focus/scroll behaviour for screen readers and other assistive software.

Read more about it here: https://github.com/alphagov/govuk-frontend/pull/1056

lhokktyn commented 5 years ago

This is now fixed and will make its way into the next release.