Feature/ecs module

[dan-hill2802]

Can you take a look at the modules/ecs/variables.tf file and remove any defaults that are a duplication of the default specified in the root variables.tf? this will make maintaining and debugging easier in the future

[dan-hill2802]

Error: error creating IAM Policy GHA--ecs-task-execution-ssm-policy: EntityAlreadyExists: A policy called GHA--ecs-task-execution-ssm-policy already exists. Duplicate names are not allowed.

Looks like there is an issue with the naming there, the double - suggests something isn't set or is being trimmed

[mattholmes15]

Error: error creating IAM Policy GHA--ecs-task-execution-ssm-policy: EntityAlreadyExists: A policy called GHA--ecs-task-execution-ssm-policy already exists. Duplicate names are not allowed.

Looks like there is an issue with the naming there, the double - suggests something isn't set or is being trimmed

There was an issue with one of the pipelines where it didn't clean down properly, looks like I may have missed this - I'll check

[mattholmes15]

Can you take a look at the modules/ecs/variables.tf file and remove any defaults that are a duplication of the default specified in the root variables.tf? this will make maintaining and debugging easier in the future

Done

[mattholmes15]

Can you also update the README to reflect the changes. When referring to the ECS deployment type in the README, you should state that currently, only Fargate is supported.

README updated

[mattholmes15]

Can you prefix the variable descriptions in variables.tf with (Optional) when they have defaults?

Done

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication