sysvinit script doesn't verify solr process actually running and restart if needed

dwradcliffe / chef-solr

Chef cookbook for solr.

http://community.opscode.com/cookbooks/solr

MIT License

23 stars 39 forks source link

sysvinit script doesn't verify solr process actually running and restart if needed #34

Closed et304383 closed 8 years ago

et304383 commented 8 years ago

    if [ -f $PIDFILE ]; then
        PID=`cat $PIDFILE`
        echo $NAME already running: $PID
    else

This should be changed to check the process list for the process ID in question, verify it's a java process running solr.jar, and if that check isn't successful remove the stale PIDFILE and start solr.

I've been burned by running service solr start returning "running" when it's not actually running.