search

dwrensha / gitlab-sandstorm

GitLab as a Sandstorm app
20 stars 8 forks source link

Image uploads in Issues and Wiki don't display #11

Closed keybits closed 8 years ago

keybits commented 9 years ago

image

The link that is generated when uploading an image is of the form:

![P1060458](http://should-use-relative-url-here:10000/gitlab/repo/uploads/951c29aab3e7d12e67b78060f6ed4699/P1060458.JPG)

dwrensha commented 9 years ago

Thanks for reporting this.

As you might be able to tell from the link text, the problem here is that GitLab is trying to use a statically-configured absolute URL for the image. That's not going to work because Sandstorm serves every session from a fresh unguessable host. So we'll need to find where in the source code GitLab is generating these links and convert them to relative URLs instead.

dwrensha commented 8 years ago

Fixed in the verison that I published just now: https://apps.sandstorm.io/app/zx9d3pt0fjh4uqrprjftgpqfwgzp6y2ena6098ug3ctv37uv6kfh