"Create new milestone" in new issue dialogue diverts to new browser window

dwrensha / gitlab-sandstorm

GitLab as a Sandstorm app

20 stars 8 forks source link

"Create new milestone" in new issue dialogue diverts to new browser window #17

Open zeigerpuppy opened 8 years ago

zeigerpuppy commented 8 years ago

When clicking on "Create new milestone" in the issue dialogue, gitlab opens a new window/tab (without the sandstorm surrounds).

Also, when the new milestone is added, it's not immediately available to assign the issue too back in the parent window.

Also, when milestones are created and issues assigned to them, the counter for milestones doesn't increment in the main gitlab menu (even with a browser refresh, restarting app or going to settings and back to menu).

Maybe a callback misdirecting? 2016-05-13 12 51 12 pm

dwrensha commented 8 years ago

When clicking on "Create new milestone" in the issue dialogue, gitlab opens a new window/tab (without the sandstorm surrounds).

That's unfortunate. I wonder whether it would be better for us to open in the current tab, or to just disable this link.

Some related discussion is here: https://github.com/sandstorm-io/sandstorm/issues/1848

Also, when the new milestone is added, it's not immediately available to assign the issue too back in the parent window.

It looks like this is also the case on gitlab.com, so I guess it's an upstream problem.

the counter for milestones doesn't increment in the main gitlab menu

Where is this counter? Maybe you could post a screenshot.

zeigerpuppy commented 8 years ago

It's a useful function to have to be able to add milestones from the issues menu but I see the difficulty with making this work, it would probably require that a new dialogue appears rather than a new window. perhaps it may be best to disable it for now (although it does break the workflow) or warn the user that it opens in a new window.

I assume that the menu on the left should say the number of milestones next to "Milestones", like it does for issues. Maybe not?

Sorry, this is the first time I use gitlab!

dwrensha commented 8 years ago

I assume that the menu on the left should say the number of milestones next to "Milestones", like it does for issues. Maybe not?

Such a number does not appear on gitlab.com:

zeigerpuppy commented 8 years ago

fair enough, no need to diverge from upstream then

xet7 commented 6 years ago

This issue was moved to sandstormports/gitlab-sandstorm#11