search

dwrensha / gj

event loop and promises in Rust
MIT License
110 stars 13 forks source link

wrong? comment #10

Closed astraw closed 8 years ago

astraw commented 8 years ago

Hi, I was reading the comments for EventLoop._run() (here) and they seem to be out of sync with the implementation.

This never calls the `EventPort`'s `sleep()` or `poll()`. It will
call the `EventPort`'s `set_runnable(false)` if the queue becomes empty.

Unless I'm mistaken somehow, there is no sleep() or poll() for EventPort nor does EventPort have set_runnable().

dwrensha commented 8 years ago

Thanks. gj started out as a more-or-less literal port of kj, and this is one of the vestiges. Removed.