setting up a pre-commit hook

dwyl / abase

:house: A (solid) Base for your Web Application.

9 stars 0 forks source link

setting up a pre-commit hook #27

Closed samhstn closed 7 years ago

samhstn commented 7 years ago

Fixes #22

jrans commented 7 years ago

@shouston3 Not sure this is a PR right now as you've already pushed this to master but please add to PR immediately with:

[x] eslint in dev-dependencies
[x] istanbul.yml file
[x] change test script to either
- run test files with duffix .test.js not just .js as stops us from adding helpers or fixtures to the test folder
- The proposed solution in #23 where we use index.js as the runner and test command runs just that file which will require in the rest.

jrans commented 7 years ago

an example of a .istanbul.yml file is

verbose: false
instrumentation:
  root: ./src
  excludes: []
  include-all-sources: true
check:
  global:
    branches   : 100
    functions  : 100
    lines      : 100
    statements : 100

which reduces the package.json command also

jrans commented 7 years ago

@shouston3 conflicts to be resolved

jrans commented 7 years ago

@shouston can you mention #22 in your commit messages

samhstn commented 7 years ago

Fixes #22

jrans commented 7 years ago

may want a .eslintignore file

samhstn commented 7 years ago

Added the .eslintignore file ⬆️

jrans commented 7 years ago

👍 Well done Sam

nelsonic commented 7 years ago

@jrans not a fan of having another configuration file in the project ... what does .istanbul.yml give us that cannot be included in the script in package.json ... e.g: https://github.com/dwyl/hapi-auth-jwt2/blob/c2fe39237e1f1c6dc2ae2d6aae38e00dc343ded7/package.json#L61

samhstn commented 7 years ago

reverted back to having all the istanbul config in coverage script in #29