SQL Generation - Githubissues

dwyl / abase

:house: A (solid) Base for your Web Application.

9 stars 0 forks source link

SQL Generation #31

Closed jrans closed 7 years ago

jrans commented 7 years ago

THIS PR

Main issue: #11

In this PR we create handlers for db interactions:

create table
- validates config object is good #39 before creating table with columns of correct type
insert
- takes object of the form { fields }
update
- takes object of the form { fields, where }
delete
- takes object of the form { where }
select
- takes object of the form { select, where }

Check update to README.md to see necessary steps to run db tests. #34

nelsonic commented 7 years ago

@looks promising. assign when ready. 👍

nelsonic commented 7 years ago

@eliascodes you have assigned me this PR but the build is failing... should I still start reviewing...?

eliasmalik commented 7 years ago

@nelsonic the build is failing b/c there's no travis YAML (it's on @SimonLab 's PR) so travis is trying to run the node app in ruby. If you run the tests manually, they all pass. There are linter errors, but we want to sort those out in a separate PR (see #46). So I think this PR is OK to review! 👍

eliasmalik commented 7 years ago

Have now:

merged with master
sorted conflicts
fixed linter errors (@shouston3)
added postgres to travis config to fix failing tests

@nelsonic please have a look!

nelsonic commented 7 years ago

WoW! 830 Lines ... better get to it! 👀

nelsonic commented 7 years ago

Code looks good. merging. 👍