dwyl / abase

:house: A (solid) Base for your Web Application.
9 stars 0 forks source link

Unique constraint for fields #55

Closed jrans closed 7 years ago

jrans commented 7 years ago

THIS PR

Related: #54

jrans commented 7 years ago

will reassign when #48 in

nelsonic commented 7 years ago

@jrans assign when ready... 😉

nelsonic commented 7 years ago

@jrans please see: https://github.com/dwyl/abase/issues/54#issuecomment-250471224 (code looks good, just that open question regarding the naming decision...)

jrans commented 7 years ago

@nelsonic ok changed, I agree unique is much nicer just was being super safe and can always change back if we encounter the problem!

codecov-io commented 7 years ago

Current coverage is 100% (diff: 100%)

Merging #55 into master will not change coverage

@@           master   #55   diff @@
===================================
  Files          10    10          
  Lines         174   183     +9   
  Methods        38    40     +2   
  Messages        0     0          
  Branches       25    27     +2   
===================================
+ Hits          174   183     +9   
  Misses          0     0          
  Partials        0     0          

Powered by Codecov. Last update d6d0fc9...9137db2

nelsonic commented 7 years ago

Thanks Jack! 👍