search

dwyl / abase

:house: A (solid) Base for your Web Application.
9 stars 0 forks source link

Password hash #65

Closed jrans closed 5 years ago

jrans commented 7 years ago

THIS PR

Assumes password field exists when inserting new user data. Hashes the password field entry with bcrypt. #52

I feel #58 is a much better approach as this way to hardcoded for my liking and going against the flow of things but this is the MVP solution

Integration branch #64 has used the old solution.

Note the hashing on inserts has meant that promises aren't returned from db.insert so the cb method must be used here unless we want to promisify bcrypt.

codecov-io commented 7 years ago

Current coverage is 100% (diff: 100%)

Merging #65 into master will not change coverage

@@           master   #65   diff @@
===================================
  Files          10    10          
  Lines         180   198    +18   
  Methods        39    42     +3   
  Messages        0     0          
  Branches       26    28     +2   
===================================
+ Hits          180   198    +18   
  Misses          0     0          
  Partials        0     0

Powered by Codecov. Last update 593dcec...6348c5c