Open thegsi opened 8 years ago
Not sure why the timeout approach has been adopted. 1) Could the equals go inside the fs functions' callbacks. 2) Could you use the sync versions of the fs functions? 3) If the seTimeout is required perhaps a comment could be useful to explain.
https://github.com/dwyl/adoro/blob/BLCRS/test/tests.js#L38 https://github.com/dwyl/adoro/blob/BLCRS/test/tests.js#L58
Not sure why the timeout approach has been adopted. 1) Could the equals go inside the fs functions' callbacks. 2) Could you use the sync versions of the fs functions? 3) If the seTimeout is required perhaps a comment could be useful to explain.
https://github.com/dwyl/adoro/blob/BLCRS/test/tests.js#L38 https://github.com/dwyl/adoro/blob/BLCRS/test/tests.js#L58