dwyl / alog

🌲 alog (Append-only Log) is an easy way to start using the Lambda/Kappa architecture in your Elixir/Phoenix Apps while still using PostgreSQL (with Ecto).

GNU General Public License v2.0

15 stars 2 forks source link

Insert #50

Closed RobStallion closed 5 years ago

RobStallion commented 5 years ago

45

"alog-ifies" insert functionality, adding a CID made from the params and a unique entry_id from a substring of the CID.

Adds tests for insert function

This step, as it is currently, allows for duplicate data to be inserted. Comments have been added to code for my thoughts on this matter.

RobStallion commented 5 years ago

@Danwhy I do not think that this PR is complete (at all) but I think that it might be in a place that it can be merged into the adapter branch.

Please let me know if you have any thoughts on this.

Danwhy commented 5 years ago

I think if we add some tests, we may get a better idea of how we want it to actually work/what makes sense with regards to duplicate data etc.

You'll need to delete or comment out all the old tests that have use Alog in them to run any tests you write. Take a look at the update test on my update branch if you need any help getting started.

RobStallion commented 5 years ago

Testing the insert functions has 'brought to light' some things that we could (and maybe should) change in the future. Please see this comment for more info on this.