Publish - Githubissues

dwyl / ampl

:iphone: :zap: Ampl transforms Markdown into AMP-compliant html so it loads super-fast!

GNU General Public License v2.0

58 stars 3 forks source link

Publish #13

Closed des-des closed 8 years ago

iteles commented 8 years ago

Hey @des-des, I'm super excited that you're keen to work on this! :raised_hands:

This is totally my bad as I haven't documented this anywhere useful (thanks for the reminder!) but as an exercise both in practice for upcoming projects and in setting an example for collaborators, would it be OK to do the following in PRs from now on please?:

Add a description to the PR so that people can follow along with what's being done
Assign to someone else for code review and merge

(and in this case, don't merge before the build has passed even if it's not a code change :wink:)

des-des commented 8 years ago

Hiya @iteles. Yeah on point one totes my bad..

Today I have sorta been merging to a submaster branch. If I end up doing a bunch of work on different features could I merge them all together then assign someone else for the master merge or should I leave them all up to be merged one by one?

nelsonic commented 8 years ago

@des-des yeah, sub-feature branches are cool. I've been watching the PRs and they are fine. busy reviewing the "main" feature branch/PR: https://github.com/dwyl/ampl/pull/5 looks good. adding comments/issues as I go. :+1:

iteles commented 8 years ago

Agreed gents, much more relevant/important when merging to master (hard to tell on my phone - the GH mobile interface really is kind of awful!). Thanks for clarifying @des-des :smiley: