Closed nelsonic closed 8 years ago
Build passes on Travis, but no coverage info collected: https://travis-ci.org/dwyl/ampl/builds/103661684#L272
easy quick fix is to write tests in es5 and test the lib folder rather than src. atm they are not really benefiting from from es6 features
@des-des agree that when no ES6 amazing benefits are required we should default
to using _ES6_ however at the moment the tests are import
ing the src
files ...
so we would need to switch to using the lib/ampl.js
instead which would mean running npm run build
before running the tests...
ops I think we are both pushing solutions to this. my bad.
@des-des if you have time to investigate this, please assign to yourself and I'm happy to work on other stuff. you'll probably figure it out fastererer than me... :racehorse:
ill give it a go
@des-des <3
@des-des did you see: https://github.com/ambitioninc/babel-istanbul/issues/51#issuecomment-173326875 ? I've just pushed a commit that _might_ work... https://travis-ci.org/dwyl/ampl/builds/103678920 promise I will leave it alone after that last commit. need to catch up on work... hope you're having a good evening. (don't work toooo hard...)
maybe have too much fun..
At the moment when attempting to run the tests using
istanbul
to collect coverage stats, we get:I suspect this might have something to do with: https://github.com/gotwarlost/istanbul/issues/262#issuecomment-168280240
We should investigate _why_
istanbul
:broken_heart:babel
...