dwyl / ampl

:iphone: :zap: Ampl transforms Markdown into AMP-compliant html so it loads super-fast!
GNU General Public License v2.0
58 stars 3 forks source link

No Coverage Information Collected using Istanbul ... Babel...? #17

Closed nelsonic closed 8 years ago

nelsonic commented 8 years ago

At the moment when attempting to run the tests using istanbul to collect coverage stats, we get:

"No coverage information was collected, exit without writing coverage information"

dwyl-ampl-no-coverage-info-collected

I suspect this might have something to do with: https://github.com/gotwarlost/istanbul/issues/262#issuecomment-168280240

We should investigate _why_ istanbul :broken_heart: babel ...

nelsonic commented 8 years ago

Build passes on Travis, but no coverage info collected: https://travis-ci.org/dwyl/ampl/builds/103661684#L272

des-des commented 8 years ago

easy quick fix is to write tests in es5 and test the lib folder rather than src. atm they are not really benefiting from from es6 features

nelsonic commented 8 years ago

@des-des agree that when no ES6 amazing benefits are required we should default to using _ES6_ however at the moment the tests are importing the src files ... so we would need to switch to using the lib/ampl.js instead which would mean running npm run build before running the tests...

des-des commented 8 years ago

ops I think we are both pushing solutions to this. my bad.

nelsonic commented 8 years ago

@des-des if you have time to investigate this, please assign to yourself and I'm happy to work on other stuff. you'll probably figure it out fastererer than me... :racehorse:

des-des commented 8 years ago

ill give it a go

iteles commented 8 years ago

@des-des <3

nelsonic commented 8 years ago

@des-des did you see: https://github.com/ambitioninc/babel-istanbul/issues/51#issuecomment-173326875 ? I've just pushed a commit that _might_ work... https://travis-ci.org/dwyl/ampl/builds/103678920 promise I will leave it alone after that last commit. need to catch up on work... hope you're having a good evening. (don't work toooo hard...)

des-des commented 8 years ago

maybe have too much fun..