search

dwyl / ampl

:iphone: :zap: Ampl transforms Markdown into AMP-compliant html so it loads super-fast!
GNU General Public License v2.0
58 stars 3 forks source link

removed doctype from template #33

Closed pankajpatel closed 7 years ago

pankajpatel commented 7 years ago

Fixes #32

codecov-io commented 7 years ago

Current coverage is 100% (diff: 100%)

No coverage report found for master at c5c5f74.

Powered by Codecov. Last update c5c5f74...85d6bbb

varjmes commented 7 years ago

Hope it's okay that I merge this @nelsonic, but I guess you gave me the ability for a reason!

varjmes commented 7 years ago

You might consider PR'ing a version update in the package.json too (I consider this to just need a minor version change). How does the module get published?

nelsonic commented 7 years ago

@Charlotteis that is indeed why you have the "power"; because you can be are trusted. ❤️ ✅ 🚀

pankajpatel commented 7 years ago

@nelsonic how would package version move forward?

nelsonic commented 7 years ago

@pankajpatel ampl@1.0.6 on NPM has the changes you have made. thanks again! 🎉

iaincollins commented 7 years ago

Hi, version 1.0.6 on NPM still has the bug from #32.

The <!doctype html> is still emitted in the body (and is missing from start of the page, which is flagged as invalid by the validator at https://validator.ampproject.org/).