dwyl / ampl

:iphone: :zap: Ampl transforms Markdown into AMP-compliant html so it loads super-fast!
GNU General Public License v2.0
58 stars 3 forks source link

Es6 #5

Closed des-des closed 8 years ago

des-des commented 8 years ago
des-des commented 8 years ago

this pull should solve #1

des-des commented 8 years ago

@nelsonic not sure if this should be more polished before we merge with master ...

nelsonic commented 8 years ago

as it stands this PR does not include any update to the README.md file ... you don't want to set a precedent for not adding documentation to your PRs... see: https://github.com/dwyl/ampl/tree/a9fe0988c99f9bd98fadcb1d4e553a70303fd2de Issue opened: https://github.com/dwyl/ampl/issues/15

nelsonic commented 8 years ago

@des-des Travis is Happy so I'm quite content to merge this PR. However the Heroku Demo App is not so happy: https://github.com/dwyl/ampl/issues/16 Do you have time to see why...?

nelsonic commented 8 years ago

@des-des we need to collect coverage data for the tests. annoyingly, when we attempt to run the tests using istanbul no coverage data is collected. see: https://github.com/dwyl/ampl/issues/17

nelsonic commented 8 years ago

@des-des good idea to transpile before running tests on Travis :bulb: did this work on your local ...?

des-des commented 8 years ago

@nelsonic trying on local defo much faster than pushing and waiting for travis ...

nelsonic commented 8 years ago

@des-des when I run anything involving babel on my local machine it takes ages... :disappointed: I think I might have to sit with you some time to see how you make it go faster... :racehorse:

nelsonic commented 8 years ago

@des-des yes, if we are going to ES5 the tests ...

however that still requires the babel build on Travis which we would similarly need to run on local... I'm experimenting with babel-istanbul so that any ES6 code in the project (including in the /test dir) will be transpiled _before_ the tests are run ...

Thoughts...? :thought_balloon:

Safe journey. :bullettrain_side:

cc: @rjmk how are you tracking code coverage in your babel-powered projects...?

codecov-io commented 8 years ago

Current coverage is 100.00%

Branch #5 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found. Review entire Coverage Diff as of d5be481

Powered by Codecov. Updated on successful CI builds.

nelsonic commented 8 years ago

@des-des so... this might work... https://travis-ci.org/dwyl/ampl/builds/103683244#L297 what do you think...?

nelsonic commented 8 years ago

@des-des would you mind investigating the coverage and adding a couple more test cases to cover the conditional branches that are not being executed...?

des-des commented 8 years ago

:sparkles: woop on it

des-des commented 8 years ago

image

nelsonic commented 8 years ago

Ok. this is acceptable code. :stuck_out_tongue_winking_eye: Nice one @des-des :+1:

nelsonic commented 8 years ago

@des-des totes merging into Master as a first version. Great work! :+1: