dwyl / app-mvp-elm

:palm_tree: The Elm MVP @dwyl application
https://app-mvp-elm.herokuapp.com/
GNU General Public License v3.0
7 stars 0 forks source link

Stop timer when capture completed #26

Closed SimonLab closed 4 years ago

SimonLab commented 4 years ago

At the moment it is possible to complete a capture while a timer is running: timer-capture-completed

We can either:

iteles commented 4 years ago

Personally, I feel like the second item is more intuitive.

If I'm marking something as complete, then I'm now no longer working on it. Having to stop the timer and then mark as completed adds unnecessary steps! This should also be an option (stopping the timer and then marking as completed) of course but I would suggest that stopping the timer when an item is marked as complete should be the natural course.

SimonLab commented 4 years ago

The timer is now stopped if the capture is in progress before changing the capture to "completed" stop-timer-complete

nelsonic commented 4 years ago

Looks great @SimonLab 🎉