dwyl / app-mvp-elm

:palm_tree: The Elm MVP @dwyl application
https://app-mvp-elm.herokuapp.com/
GNU General Public License v3.0
7 stars 0 forks source link

Use auth service UI for authentication #32

Open SimonLab opened 4 years ago

SimonLab commented 4 years ago

Currently the Github and Google login buttons' urls are retrieved from the API and Elm is responsible for displaying them on the page. Instead we can delegate the authentication responsibility to the authentication service directly. Once loggedin the auth service should be able to redirect the user to the Elm application.

nelsonic commented 4 years ago

@SimonLab thanks for opening this issue to refactor Auth. 👍 Please ensure there is a diagram explaining the flow (if not, please create a new slide in the Google doc): https://docs.google.com/presentation/d/1PUKzbRQOEgHaOmaEheU7T3AHQhRT8mhGuqVKotEJkM0

Auth is the one thing we have to document like our lives depend on it. 😉

SimonLab commented 4 years ago

To be able to test easily the changes without breaking the current authentication application, I've created a new Google OAuth application and deploy a copy of github.com/dwyl/auth-mvp/ to Heroku: https://auth-mvp-test.herokuapp.com/auth/urls

From there once the new deployed auth service is ready I can test it on localhost with the Elm application.