dwyl / auth

🚪 🔐 UX-focussed Turnkey Authentication Solution for Web Apps/APIs (Documented, Tested & Maintained)
https://authdemo.fly.dev
GNU General Public License v2.0
135 stars 9 forks source link

add scope repo for oauth with Github #184

Closed SimonLab closed 2 years ago

SimonLab commented 2 years ago

ref: https://github.com/dwyl/auth/issues/182

This PR add manually the "repo" scope which gives read/write access to repository when using oauth token.

codecov[bot] commented 2 years ago

Codecov Report

Merging #184 (6d5c372) into main (e121667) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #184   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          586       586           
=========================================
  Hits           586       586           
Impacted Files Coverage Δ
lib/auth_web/controllers/auth_controller.ex 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e121667...6d5c372. Read the comment docs.

SimonLab commented 2 years ago

Indeed this is not a perfect solution as it changed the scope for all the applications created with auth. I'll add checkboxes in the UI when creating a new app to select which scope to add