dwyl / auth

🚪 🔐 UX-focussed Turnkey Authentication Solution for Web Apps/APIs (Documented, Tested & Maintained)
https://authdemo.fly.dev
GNU General Public License v2.0
131 stars 9 forks source link

Chore: Fix Failing Auth Tests #235

Closed nelsonic closed 1 year ago

nelsonic commented 1 year ago

As noted in: https://github.com/dwyl/auth/pull/231#issuecomment-1283586899 Tests are still failing on CI ... https://github.com/dwyl/auth/actions/runs/3276606455/jobs/5392858413 image

The good (? 🤷‍♂️ ) news is that they are also failing on my localhost ...

image

This is less interesting than working on features ... But given that it's BLOCKED progress, it's my priority for the morning ... ⏳

nelsonic commented 1 year ago

6 tests failing on localhost ... picking the first one off now. 🧑‍💻 ⏳

nelsonic commented 1 year ago

Is GitHub suuuuper Slow for anyone else? 🤷‍♂️ image

nelsonic commented 1 year ago

Tests finally fixed. ✅

https://github.com/dwyl/auth/actions/runs/3288930149/jobs/5420598380 image

https://github.com/dwyl/auth/actions/runs/3288930149/jobs/5420598380#step:7:247 image

The fix was a loooot simpler than I thought; just updating all the environment variables and specifically AUTH_API_KEY, AUTH_URL, ENCRYPTION_KEYS and SECRET_KEY_BASE

https://github.com/dwyl/auth/settings/secrets/actions image

Working now. Back to docs! #231