search

dwyl / auth

πŸšͺ πŸ” UX-focussed Turnkey Authentication Solution for Web Apps/APIs (Documented, Tested & Maintained)
https://authdemo.fly.dev
GNU General Public License v2.0
131 stars 9 forks source link

Remove Ping #241

Closed SimonLab closed 1 year ago

SimonLab commented 1 year ago

As we don't use Heroku anymore for auth we can remove the ping related code.

codecov[bot] commented 1 year ago

Codecov Report

Merging #241 (a9d874b) into main (f6a7210) will not change coverage. The diff coverage is n/a.

:exclamation: Current head a9d874b differs from pull request most recent head d849f0c. Consider uploading reports for the commit d849f0c to get more accurate results

@@            Coverage Diff            @@
##              main      #241   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        26    -1     
  Lines          586       584    -2     
=========================================
- Hits           586       584    -2
Impacted Files Coverage Ξ”
lib/auth_web/router.ex 100.00% <ΓΈ> (ΓΈ)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

nelsonic commented 1 year ago

Good plan. πŸ‘Œ I think once we phase out heroku from our stack we can repurpose the ping project for something else. πŸ’­

nelsonic commented 1 year ago

@SimonLab LMK when you feel this is mergeable. πŸ‘Œ Demo version deployed to Fly.io: https://authdemo.fly.dev/people image

nelsonic commented 1 year ago

@SimonLab Want to close this PR and re-open with the gen-erd-#207 as target branch? πŸ’­

SimonLab commented 1 year ago

Closing as auth will be rebuild without ping as Fly.io is used instead of Heroku