search

dwyl / comments-you-will-regret-blocker-chrome-extension

:speak_no_evil: [WiP] A Chrome Extension that monitors comments typed into a textarea and blocks you from posting silly things you will regret!
GNU General Public License v2.0
9 stars 1 forks source link

Lint with `npm test`. #5

Closed ryanpcmcquen closed 7 years ago

ryanpcmcquen commented 7 years ago

Signed-off-by: Ryan Terra ryan.mcquen@Ryans-Mac-Pro.local

iteles commented 7 years ago

@ryanpcmcquen Thanks for getting this off to a flying start! :tada:

Have you taken a look at https://github.com/dwyl/contributing ? We find it's always best practice to start with opening issues on the proposed features/tasks, have the need verified by one other person and then assign a PR to someone who hasn't written the code for a quick review before they merge :blush:

Just to make sure there's a process in place for folks making improvements on this later!

nelsonic commented 7 years ago

Yeah, as @iteles mentioned we prefer all commits to be linked to a user-story (even a technical one) and PRs assigned to another person in the team for review ...

@ryanpcmcquen to be eligible for next year's Thank You Reward we'll need to stay reasonably close to DWYL's https://github.com/dwyl/contributing guide on this ... 😉 What's more, we are going to be implementing Hyper Transparency" in our org in 2017 which will mean that we will be allocating a sizeable amount of the profits of the Biz to share with all the team members! and putting the "Now That Reward" Gift to a vote! ✅ So you will be able to get Anything You Need just for being a part of building something open source that solves a real human challenge! 😮

But, yeah, following the "process" is important to us. thanks again! ❤️

issue raised requesting help with code review: https://github.com/dwyl/comments-you-will-regret-blocker-chrome-extension/issues/10

ryanpcmcquen commented 7 years ago

Thank you! Sorry about rushing into things, I will ask for a posthumous code review and make sure any future items are based off of issues.

iteles commented 7 years ago

@ryanpcmcquen We definitely appreciate your enthusiasm! :heart: