search

dwyl / comments-you-will-regret-blocker-chrome-extension

:speak_no_evil: [WiP] A Chrome Extension that monitors comments typed into a textarea and blocks you from posting silly things you will regret!
GNU General Public License v2.0
9 stars 1 forks source link

Use 'standard' and es6 for code and style? #8

Open ryanpcmcquen opened 7 years ago

ryanpcmcquen commented 7 years ago

Does anyone have any objections to using as many es6 features as we have available in Native Chrome?

Also any objections to using standard as our linter/style? http://standardjs.com/

nelsonic commented 7 years ago

@ryanpcmcquen it would be nice to make this plugin available in Firefox too... what do we need to do now to make it cross-plaform later on ...?

with regards to using feross/standard would prefer to use "goodparts" because using fewer features of the language will make the code more beginner friendly ... see: https://github.com/dwyl/learn-tdd/issues/72#issuecomment-258276110 but since you are leading the Dev on this, provided it works in Chrome, we can use ES6 ...

nelsonic commented 7 years ago

@ryanpcmcquen how is your elm-lang ...? In 2017 we are migrating to using elm everywhere we used to use JS because of these reasons: https://github.com/dwyl/learn-elm/#why If you're unfamiliar with it, watch: https://youtu.be/R2FtMbb-nLs and let us know what you think... 👍

nelsonic commented 7 years ago

@andrewMacmurray would you use elm-lang for this...? 😉

andrewMacmurray commented 7 years ago

@nelsonic sure, I could definitely see myself using elm for this 😄

I imagine it would work nicely for managing how and when to show the user information on the comments they are writing and you wouldn't have any js compatibility issues (I think elm code compiles into es3 so excellent browser support).

You'd probably still need some non elm code to get the right info into the elm app (the content in the text boxes will be outside the elm app initially).

Ultimately it would all depend on how comfortable the team is using elm, some of it is a little mind bending at the beginning but once you get the hang of it it's a total dream to use ✨

ryanpcmcquen commented 7 years ago

I have not used elm. For my own experience I would prefer using Native JavaScript that works in Chrome and Firefox without any transpiling.

varjmes commented 7 years ago

Elm adds an overhead that might not be friendly for beginners. If you're going to use ES6, it might be a good idea to write down what we can / cannot use in this repo and how many versions of Chrome / FF will be supported. Also I'm not sure if FF/Chrome support the same things in ES6 or not.