search

dwyl / contributing

:clipboard: Guidelines & Workflow for people contributing to our project(s) on GitHub. Please :star: to confirm you've read & understood! :white_check_mark:
88 stars 9 forks source link

Draft Pull Requests! #111

Open nelsonic opened 5 years ago

nelsonic commented 5 years ago

Instead of adding "[WiP]" to a pull request we can now create it as a "Draft": https://github.blog/2019-02-14-introducing-draft-pull-requests/ image

SimonLab commented 5 years ago

I notice that if you put your PR to "ready for review" then the last test on the CI is triggered to check that the PR can be merged: image

It means that you can in theory have a PR ready for review but it's possible that the last test is failing, so we might still need to double check that all tests are ok before adding the "awaiting review" label

nelsonic commented 5 years ago

@SimonLab thanks for investigating this and confirming 👍