search

dwyl / contributing

:clipboard: Guidelines & Workflow for people contributing to our project(s) on GitHub. Please :star: to confirm you've read & understood! :white_check_mark:
88 stars 9 forks source link

Notes on Code Reviews (Where do they go in DWYL Org...?) #61

Open nelsonic opened 7 years ago

nelsonic commented 7 years ago

My "Notes on Code Reviews" (which I poured time into) have been completely ignored ... 😞 https://github.com/foundersandcoders/master-reference/blame/b6a52ccd9c0a4f6728a75988c48dd844f8dc1a59/coursebook/general/code-reviews.md (I don't think anyone has ever read them...)

Where should I put them in the @DWYL Org...?

nelsonic commented 7 years ago

I think the can be (dramatically) edited/paired down/improved ... and I will iterate on them and Push my changes back to F&C's "Master Reference" but they need a better home where they aren't buried under two levels of directories... 😕

iteles commented 7 years ago

With our current structure, this tepo is where we're collecting the end-to-end process of doing what we currently do for clients. That may need to be rethought/broken out into smaller md files or repos.

nelsonic commented 7 years ago

@iteles the "popularity" of the https://github.com/dwyl/ateam-master-reference reflects how many people have actually read it ... ateam-master-reference

For this to be considered "useful" there should be a commit for an enhancement from everyone in the DWYL Team...

Currently it looks forgotten and unloved 💔 There is a lot of interesting topics in the issues: https://github.com/dwyl/ateam-master-reference/issues 😍 but it does not appear to be getting into the main Readme... 🤔

nelsonic commented 7 years ago

I'm in favour of concentrating our efforts in One place. Here. https://github.com/dwyl/contributing

We will point to this repo from all our other projects e.g: https://github.com/dwyl/hapi-auth-jwt2/blob/master/CONTRIBUTING.md