search

dwyl / contributing

:clipboard: Guidelines & Workflow for people contributing to our project(s) on GitHub. Please :star: to confirm you've read & understood! :white_check_mark:
86 stars 9 forks source link

PR Review Process is Unclear ... :-( #64

Closed nelsonic closed 7 years ago

nelsonic commented 7 years ago

as a team member (developer) want to ship my work to end-users ASAP I need to know what the QA/review process is so that I know when I can expect my work on this PR/story is considered done. (so that I'm not waiting to start work on my next story...)

Pain felt by team member: unclear-on-pr-review-process

Let's fix this now!

relates to: https://github.com/dwyl/contributing/issues/32#issuecomment-271089111

ghost commented 7 years ago

I agree. this needs to be clarified. especially for beginners. 👍

nelsonic commented 7 years ago

Should we consider dissalowing merging one's own Pull Request on GitHub? http://stackoverflow.com/questions/23858386/disallow-merging-your-own-pull-request-on-github Or is there a situation where being able to merge your own PR is useful?

iteles commented 7 years ago

Nope. Let's disallow merging of one's PR until we find the exception. In 2 years we've never yet had to do this.

nelsonic commented 7 years ago

Use the GitHub Review process: review-changes-submit

nelsonic commented 7 years ago

multiple-reviewers

It's not uncommon to see a PR with multiple review approvals. this is our "peer review" process working to share knowledge & code understanding among the team. ✅

iteles commented 7 years ago

@nelsonic Can this now be closed?

nelsonic commented 7 years ago

@iteles yes! someone else can open a more specific question if/when they need to. 👍