Closed mk4111 closed 7 years ago
@mk4111 superb question! 👍
There's a note for this lower down: https://github.com/dwyl/contributing/blame/4f38e20b95eb6d3a950e6f8f9f44bbd977ae87d8/README.md#L621-L623
But it still isn't specific that you can assign it to:
the Project/Team Lead or "QA" (where applicable) or in the case of an open source module, our "rule-of-thumb" is: look at the list of contributors and assign your PR to the person who has made the most contributions. if you are unable to assign your PR, simply mention the person's by name in your PR description to notify them that your PR is "ready for review".
The general guideline that your PR should be assigned to "someone else" was simply to remind people not to be tempted to merge their own PRs... I agree that we should be specific on who you can/should assign it to... 👍
Please PR a clarification. Specifically add a "Question" to the "FAQ" section. thanks! (if unclear please let us know!) 👍 relates to: #71
@nelsonic, that makes sense! I'll add a Question to FAQ
right away! Thank you for the clarification! Yippeeeee
Closing this as has been resolved by #92
If somebody on the other side of the world wants to contribute to dwyl repos, but knows nobody but the validator of their issue, should this person be assigned the PR to the issue raised when it is ready for review?
I think it could be handy to suggest this somewhere in the repo - maybe here?