search

dwyl / contributing

:clipboard: Guidelines & Workflow for people contributing to our project(s) on GitHub. Please :star: to confirm you've read & understood! :white_check_mark:
86 stars 9 forks source link

Example of a Terrible Pull Request (Worst Case Scenario) #78

Open nelsonic opened 7 years ago

nelsonic commented 7 years ago

This person has not followed a single step in the Contributing Guide... 😢 how-not-to-do-a-pull-request It's clear they either have limited GitHub Experience or that they are used to working alone. Either way this is a communication and teamwork antipattern that must be avoided.

After committing directly to master this is the next worst thing. 😞

🤖 DWYLBOT will reject this kind of Pull Request by leaving a comment advising the person to view the Contributing Guide.

JoseCage commented 7 years ago

Awesome idea.

🤖 DWYLBOT will reject this kind of Pull Request by leaving a comment advising the person to view the Contributing Guide.

How can i contribute in this project/idea? @nelsonic

iteles commented 7 years ago

@JoseCage We're defining it over the next week here: https://github.com/dwyl/dwylbot/issues

We'll be building it in our new stack: https://github.com/dwyl/technology-stack/#the-pete-stack

JoseCage commented 7 years ago

Right @iteles .. Thanks.. 🔼