search

dwyl / dwyl-site

:eyes: The dwyl website (please tell us what you think!)
https://dwyl.com
33 stars 14 forks source link

adds cookie notification #421

Closed ZooeyMiller closed 7 years ago

ZooeyMiller commented 7 years ago

In compliance with EU regulation this adds a notification that we set a cookie (GTM). If the user has JS enabled then there is the option of clicking a button so that the notification does not show again (using localStorage), if not they are told that the bar will continue to show due to them having JS disabled.

420

dwylbot[bot] commented 7 years ago

@ZooeyMiller, hoorah! 🎉 It's review time! 👀

I couldn't help but notice that there isn't an in-progress label on this pull request and a Reviewer has been added...makes me think that this pull request is ready for review 🤔

To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review label - automatically - just like magic! 🎩 🐰 ✨. Please correct me if I'm wrong, but if I got it right this time I hope it helps you! 😄

Any questions, complaints, feedback, contributions? Discuss If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

dwylbot[bot] commented 7 years ago

@ZooeyMiller, hoorah! 🎉 It's review time! 👀

I couldn't help but notice that there isn't an in-progress label on this pull request and a Reviewer has been added...makes me think that this pull request is ready for review 🤔

To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review label - automatically - just like magic! 🎩 🐰 ✨. Please correct me if I'm wrong, but if I got it right this time I hope it helps you! 😄

Any questions, complaints, feedback, contributions? Discuss If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

dwylbot[bot] commented 7 years ago

@ZooeyMiller, hoorah! 🎉 It's review time! 👀

I couldn't help but notice that there isn't an in-progress label on this pull request and a Reviewer has been added...makes me think that this pull request is ready for review 🤔

To save you time ⏳ I've added the Reviewer as an Assignee and I've added the awaiting-review label - automatically - just like magic! 🎩 🐰 ✨. Please correct me if I'm wrong, but if I got it right this time I hope it helps you! 😄

Any questions, complaints, feedback, contributions? Discuss If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new

ghost commented 7 years ago

Merging as this is required by law and it works (nice spot zooey), but perhaps the design of this could be somewhat improved, so creating a new issue https://github.com/dwyl/dwyl-site/issues/427