search

dwyl / dwyl-site

:eyes: The dwyl website (please tell us what you think!)
https://dwyl.com
33 stars 14 forks source link

changed blog link in nav to not always be highlighted, instead highli… #436

Closed Rob-Rychs closed 6 years ago

Rob-Rychs commented 6 years ago

This should solve #431

Hard to test if the :active works because of how live-server handles the links...

Maybe try deploying it to a test-server and if the issue isn't fixed just ignore this PR

Changed blog link in nav to not always be highlighted, instead highlight on link a:hover and a:target

Rob-Rychs commented 6 years ago

Deployed my branch to netlify to test the a:target https://suspicious-raman-a5c987.netlify.com/

looks like the menu link isn't staying highlighted

This PR only half solves the issue...

Rob-Rychs commented 6 years ago

because clicking the link navigates to the link which re-renders the whole page...duh

One way I guess to solve is to get the pathname with JS, parse it to remove the root domain and then match it to the $(a.link).value() and add the .dwyl-mint class to it...

Rob-Rychs commented 6 years ago

@nelsonic thanks buddy 🙏