dwyl / dwyl-site

:eyes: The dwyl website (please tell us what you think!)
https://dwyl.com
33 stars 14 forks source link

DWYL Site Build Failing (no package.json or .travis.yml file...) #461

Closed nelsonic closed 1 year ago

nelsonic commented 6 years ago

As per the readme, the dwyl website is hosted by GitHub Pages and cached by CloudFlare: dwyl-site-hosted-with-github-pages-cloudflare-for-ssl

There is a "view it locally" section: https://github.com/dwyl/dwyl-site#viewing-locally dwyl-site-viewing-it-locally not listing dependencies in a package.json file is an "anti-pattern" and encouraging people to install things globally is undesirable because it means the person might have a different version of the package installed which leads to unexpected behaviour ... having a clear version listed in a package.json file means everyone knows it works. (yes, I know that live-server is "stable" but the principle remains, and it's the signal this sends to people reading the repo that matters...)

The package.json file was removed recently, as was the .travis.yml file and I feel this is a "regrettable" because now there are no automated tests ... 😢 dwyl-site-build-failing

I am "uncomfortable" with this because it means a human has to manually check/QA every page of the website before it can be published which either reduces our quality control workflow speed considerably or (often more likely) people "relax" their quality control.

I propose we address this.

The last known state for the pacakge.json is: https://github.com/dwyl/dwyl-site/commits/e7dd85c11094b837c3d8387f201af74e75bed53e/package.json I propose we:

To be clear: It's My (Nelson's) fault for allowing the package.json and .travis.yml file to be deleted. I am responsible for this. so I am fixing it.

nelsonic commented 1 year ago

Build still failing. 😢 But we will be re-doing the size very soon without any package.json to break. 🎉 Closing. ✅