search

dwyl / dwyl-site

:eyes: The dwyl website (please tell us what you think!)
https://dwyl.com
33 stars 14 forks source link

Make external links open in new tab #477

Closed papamarfo closed 5 years ago

papamarfo commented 5 years ago

@nelsonic My bad. I was itching to get it fixed.

papamarfo commented 5 years ago

@iteles Thanks for the heads up. @nelsonic Should i close this issue??

nelsonic commented 5 years ago

@manfordbenjamin given the links shared by @iteles above, I agree that from an accessibility perspective, we should close this PR and instead open an issue to capture why we aren't using target="_blank" for when other people ask the question. 👍