search

dwyl / dwyl-site

:eyes: The dwyl website (please tell us what you think!)
https://dwyl.com
33 stars 14 forks source link

Add new Thomas Cook logo #478

Closed Dana94 closed 5 years ago

Dana94 commented 5 years ago

Closes #467

Dana94 commented 5 years ago

I did have trouble committing this before but I thought I figured it out. I'll look into it @nelsonic

Dana94 commented 5 years ago

@iteles I'm not sure if I understand you. The issue is just asking to replace the old logo image with its new logo right?

iteles commented 5 years ago

@Dana94 Right! But the logo is currently being used in https://dwyl.com/case-studies/thomas-cook/tc-serverless, so if you change the name of the logo file, then you'll need to also change it in the code of that page (https://github.com/dwyl/dwyl-site/blob/master/case-studies/thomas-cook/tc-serverless.html) so that the updated logo actually appears ☺️

Dana94 commented 5 years ago

@iteles True, but I wouldn't need to change the file calling the image if the new logo file has the same name as the old logo file. I could do this by removing the old logo file from the repo.

This is the branch locally showing the new logo. image

Please let me know if I'm missing something.

iteles commented 5 years ago

@Dana94 That's exactly right. Both my comments mentioned if you change the file name ☺️

Dana94 commented 5 years ago

@iteles Ah gotcha, okay I did not change the file name. 😄