search

dwyl / dwyl-site

:eyes: The dwyl website (please tell us what you think!)
https://dwyl.com
33 stars 14 forks source link

Link Color Contrast is Too Low #479

Closed Dana94 closed 2 years ago

Dana94 commented 5 years ago

Referencing issue #448 Some of the links don't have a high enough color contrast ratio for accessibility.

66085867-6b289480-e540-11e9-9bfe-92305f22feb4

natastro commented 5 years ago

Hi @Dana94 ! Are you looking for what links have low contrast or for fixes? What specific colors would you be looking for? I'd be interested in looking into this :)

iteles commented 5 years ago

@Dana94 @stroudn1 Which colour hex would you propose as an alternative? I'm assuming all links on the site are the same colour but it's worth double-checking this in the CSS & HTML too!

Dana94 commented 5 years ago

@stroudn1 Great, I'll assign this to you. 😃

@iteles I haven't had a chance to go through the whole site yet but it seems the color contrast issues are primarily on the white sections of the site. For example, the links on the portfolio page.

image

I would suggest #00846a to replace the .dwyl-mint color but it does look different from dwyl's brand color so that's up to your decision if that would be acceptable.

image

natastro commented 5 years ago

Hi @Dana94 ! I just wanted to let you know I'm ready to make the pull request but I seem to be getting an error when I try to run git commit -m. I'm still trying to debug my issue. image

iteles commented 5 years ago

@stroudn1 It looks like @codybarr has submitted a PR for this already!

image

I haven't had a chance to review it yet but if you're able to take a look and add review comments (let us know if you need some help with that) maybe that would be a good first step?

Dana94 commented 5 years ago

@stroudn1 Try this:

> git commit -n You should see something like this if using Git bash, mine is Nano. image Enter in your message, it shows in yellow in the image. image Ctrl + x to save image Type y to confirm, then hit enter. image > git log to see the commit message you made.

Hope this helps!

codybarr commented 5 years ago

Sorry @stroudn1 saw this was still up for grabs. I should have checked with you first to see if you had already started work on this.

natastro commented 5 years ago

@codybarr no worries! I'm still learning/trying to fix my error. I'm going to see if I can fix it and send a PR too if that's cool with you and @Dana94

Thank you for the steps @Dana94 ! I'm going to give this a try. And thank you as well @iteles