search

dwyl / dwyl-site

:eyes: The dwyl website (please tell us what you think!)
https://dwyl.com
33 stars 14 forks source link

PR: replace google analytics with plausbile/analytics #503

Closed nelsonic closed 1 year ago

nelsonic commented 1 year ago

see: https://github.com/dwyl/technology-stack/issues/127

nelsonic commented 1 year ago

@iteles this is just the same change applied to multiple pages. ⏳ Should be a quick review. Please merge if you're happy. 🙏 :shipit:

nelsonic commented 1 year ago

Forced to add package-lock.json to GitHub otherwise CI won't pass ... see: https://github.com/dwyl/dwyl-site/actions/runs/4115415521/jobs/7104093644#step:3:12 🙄

nelsonic commented 1 year ago

BS error about package.json not being valid: https://github.com/dwyl/dwyl-site/actions/runs/4115464567/jobs/7104208455#step:4:7

image

Validated on: https://jsonlint.com

image

lame.

nelsonic commented 1 year ago

This is utter garbage. jsonlint passes on localhost!! https://github.com/dwyl/dwyl-site/actions/runs/4115564649/jobs/7104443184#step:4:11

image
nelsonic commented 1 year ago

Planning a slight update to this ... looking at: https://pypi.org/project/html5validator/

nelsonic commented 1 year ago

https://github.com/marketplace/actions/html5-validator

nelsonic commented 1 year ago

Completely removed package.json as it wasn't parsing no matter what I did! Still get this silly merge conflict blocking the PR:

image
nelsonic commented 1 year ago

@iteles please merge when you can so we can test the analytics. thanks. 👌

nelsonic commented 1 year ago

@iteles see: https://plausible.io/dwyl.com 📈