search

dwyl / dwylbot

:robot: Automating our GitHub Workflow to improve team communication/collaboration and reduce tedious repetition!
28 stars 7 forks source link

resolve bugs on merge-conflict rule #104

Closed SimonLab closed 7 years ago

SimonLab commented 7 years ago

ref #103, #102

Check for pr has the property mergeable to false instead of checking that the value is not false (issue when the value is null) Wait a bit longer for Github to update the status of the PR

codecov[bot] commented 7 years ago

Codecov Report

Merging #104 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #104   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files          20       20           
  Lines         130      130           
=======================================
  Hits          126      126           
  Misses          4        4
Impacted Files Coverage Δ
web/controllers/rules/pr/merge_conflict.ex 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d8ad751...e28e8cf. Read the comment docs.

dwylbot[bot] commented 7 years ago

:warning: @SimonLab, the pull request has a merge conflict. Please resolve the conflict and reassign when ready :+1: Thanks!

Any questions, complaints, feedback, contributions? Discuss