search

dwyl / dwylbot

:robot: Automating our GitHub Workflow to improve team communication/collaboration and reduce tedious repetition!
28 stars 7 forks source link

Adding reviewers, but not ready for review #122

Closed samhstn closed 6 years ago

samhstn commented 7 years ago

@SimonLab see here

Also dwylbot seems to have added too many awaiting-review labels here

SimonLab commented 7 years ago

Thanks @shouston3 for reporting this :+1: . I will add a condition to not assign and not add "awaiting-review" if the pr has the "in-progress" label. We are discussing when is a good time to add reviewers on a PR, see #116 , please add your thought it can help me to calibrate the rule

samhstn commented 7 years ago

I guess according to #116 I shouldn't be adding reviewers until things are ready to be reviewed I personally like knowing what I'm going to review as soon as possible even if it isn't ready, but it seems like I'm alone with this

closing

SimonLab commented 7 years ago

I reopen this, as I haven't finished to add a filter on the rule to check the in-progress label. I think you have a good point too and we will need more feedback o see how other users add reviewers

ghost commented 6 years ago

👍