Closed SimonLab closed 7 years ago
Merging #133 into master will increase coverage by
0.06%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #133 +/- ##
==========================================
+ Coverage 98.25% 98.32% +0.06%
==========================================
Files 23 23
Lines 172 179 +7
==========================================
+ Hits 169 176 +7
Misses 3 3
Impacted Files | Coverage Δ | |
---|---|---|
web/controllers/rules/pr/merge_conflict.ex | 100% <100%> (ø) |
:arrow_up: |
web/controllers/rules/pr/no_assignee.ex | 100% <100%> (ø) |
:arrow_up: |
web/controllers/rules/issue/time_estimation.ex | 100% <100%> (ø) |
:arrow_up: |
web/controllers/rules/issue/inprogress.ex | 100% <100%> (ø) |
:arrow_up: |
web/controllers/rules/issue/no_description.ex | 100% <100%> (ø) |
:arrow_up: |
web/controllers/rules/status/travis_failure.ex | 100% <100%> (ø) |
:arrow_up: |
web/controllers/github_api/in_memory.ex | 100% <100%> (ø) |
:arrow_up: |
web/controllers/rules/pr/no_description.ex | 100% <100%> (ø) |
:arrow_up: |
web/controllers/rules/pr/awaiting_review.ex | 100% <100%> (ø) |
:arrow_up: |
web/controllers/rules/issue/noassignees.ex | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 5332982...8b3ca88. Read the comment docs.
@SimonLab, a reviewer has been added to the pull request. The pull request looks ready for review (no "in-progress" label). So the reviewer has been added as an assignee and the "awaiting-reivew" label as been added to.
Any questions, complaints, feedback, contributions? If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new
@SimonLab, a reviewer has been added to the pull request. The pull request looks ready for review (no "in-progress" label). So the reviewer has been added as an assignee and the "awaiting-reivew" label as been added to.
Any questions, complaints, feedback, contributions? If you prefer, you can also send us anonymous feedback: https://dwyl-feedback.herokuapp.com/feedback/new
ref: #127
This PR abstract how dwylbot get the data from Github. It also refactor how mocks are loaded for the tests