search

dwyl / dwylbot

:robot: Automating our GitHub Workflow to improve team communication/collaboration and reduce tedious repetition!
28 stars 7 forks source link

Feature: Assign Back and Comment on PRs that do not Reference an Issue No. #140

Open nelsonic opened 7 years ago

nelsonic commented 7 years ago

Our Contributing Workflow starts with Opening an Issue: https://github.com/dwyl/contributing/tree/cc3a47b5b4d1157e35f76c0fd5dcea6c0fad20f1#part-1-describe-your-question-the-idea-or-user-story-in-an-issue

Yet we are still getting people opening PRs ignoring the "contributing guide"... 😞 (note: I know that we need to "streamline" the contributing.md, but haven't had time recently ...)

I'm trying to be "nice" / "helpful" / "welcoming" to new contributors. e.g: https://github.com/dwyl/hapi-auth-jwt2/pull/240 but the fact that the PR does not reference an issue where the feature was discussed before the PR was opened should normally be an automatic "Close and Comment" (IMO). If we open exceptions for "small features" we will get a torrent of them once our app(s) are "live"!

iteles commented 7 years ago

I would suggest we don't want to reject them, but certainly assign it back to the person who opened the PR and add a comment to explain. I think that would be 👌